Fixed consumable products reading on Android #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #439 +/- ##
=======================================
Coverage 47.69% 47.69%
=======================================
Files 4 4
Lines 478 478
=======================================
Hits 228 228
Misses 250 250 |
hyochan
reviewed
Oct 1, 2023
There was a problem hiding this comment.
@33-Elephants Thank you for your contribution! Could you kindly explain how does it fixes problem?
|
As far as I remember there was a problem with reading "price", "currency" and "localizedPrice" fields for one-time charge items. Reading product info from subscriptionOfferDetails field works for subscriptions only. For one-time charge products oneTimePurchaseOfferDetails must be used instead. |
hyochan
force-pushed
the
main
branch
2 times, most recently
from
45035a3 to
475e88d
Compare
hyochan
approved these changes
Oct 31, 2023
hyochan
added
enhancement
JoyHong
pushed a commit
to JoyHong/flutter_inapp_purchase
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.