Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #418. #423

Closed
wants to merge 2 commits into from
Closed

Fix #418. #423

wants to merge 2 commits into from

Conversation

deakjahn
Copy link
Contributor

Discussion at #418.

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #423 (e389110) into main (33b69ea) will increase coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
+ Coverage   47.69%   47.79%   +0.10%     
==========================================
  Files           4        4              
  Lines         478      477       -1     
==========================================
  Hits          228      228              
+ Misses        250      249       -1     
Impacted Files Coverage Δ
lib/modules.dart 47.22% <ø> (+0.26%) ⬆️

@deakjahn
Copy link
Contributor Author

deakjahn commented May 2, 2023

Also: "By the way, small error, toString() of IAPItem has an error, it displays two items with the label introductoryPricePaymentModeIOS, the first one is superfluous, it's a repeated display of introductoryPrice."

Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you kindly check the conflict coming from #420?

@hyochan hyochan added the bugfix label Jun 22, 2023
@deakjahn
Copy link
Contributor Author

deakjahn commented Jun 22, 2023

@hyochan That's not so simple, it was either-or, this PR was about the same error. If you merged the other, there's no need for this one.

Almost. There's still the single extraneous line in modules.dart that you could easily remove manually. It's an obvious duplicate line.

@deakjahn deakjahn closed this by deleting the head repository Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants