Upgrade to billing 5.1 (reverse compatible) #392

SamBergeron · 2022-12-02T21:58:38Z

This is build off of @youssefali424 #387 PR because that one had a couple issues. It didn't pass back the prices properly for items that were created in android billing 4.0 amongst other issues.

I created two new dart objects that reflect android 5.0 billing objects SubscriptionOffer and PricingPhase that pass back all the information associated with a play store item, so you can navigate those to extract introductory offers and discounted subscriptions as opposed to just having a single offer price.

I've also kept the price, currency and localizedPrice values and made them backwards compatible with items that were updated from billing 4.0 if your app relies on those (ours did)

~~Note that the tests fail because of ios and android receipt validation only, which appears to not point to a valid URL anymore.~~

All tests are passing and extra code coverage has been added

…s and pricing phases Reverse compatible with billing 4.0 items that have been auto migrated to 5.0 Fixed some warnings

Fix issue where "default" price was a subscription offer instead of the base plan

codecov · 2022-12-03T00:19:44Z

Codecov Report

Merging #392 (e12fe7b) into main (2ed8e1d) will increase coverage by 5.51%.
The diff coverage is 96.77%.

@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
+ Coverage   42.18%   47.69%   +5.51%     
==========================================
  Files           4        4              
  Lines         467      478      +11     
==========================================
+ Hits          197      228      +31     
+ Misses        270      250      -20

Impacted Files	Coverage Δ
lib/flutter_inapp_purchase.dart	`46.95% <87.50%> (ø)`
lib/modules.dart	`46.96% <100.00%> (+15.19%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

nizwar · 2022-12-05T00:30:45Z

Hi, i've try your PR and i got what i expected, but there is one issue in this PR and i believe its from native side

Also for minors, add toJson() and toString() on SubscriptionOfferAndroid and PricingPhaseAndroid will be much appreciated

SamBergeron · 2022-12-05T17:18:06Z

@nizwar gotcha, I didn't manually re-test all the methods I didn't modify but that error makes sense to me, I'll try and fix it today and do a bit more hands-on testing

…equired offerToken parameter needed for billing 5.0 product purchase on Android.

SamBergeron · 2022-12-29T17:42:05Z

Any chance we can get a timeline on this? Would be great to be able to not have to use a forked plugin in production

SamBergeron · 2023-01-17T22:34:25Z

@hyochan what's missing for this to be merged in? We've been using it in production for over a month without issue.

xPutnikx

Looks good, would be nice to merge it =)

hyochan

I apologize for the delay in providing a review, but I wanted to express my gratitude for your excellent work. I did have some questions, but it appears that others have already tested and reviewed your PR, so I will merge my feedback.

Thanks again for your contribution 👍

hyochan · 2023-03-07T15:41:10Z

test/flutter_inapp_purchase_test.dart

+            // expect(product.subscriptionPeriodAndroid,
+            //     expectedProduct.subscriptionPeriodAndroid);
+            // expect(product.introductoryPriceCyclesAndroid,
+            //     expectedProduct.introductoryPriceCyclesAndroid);
+            // expect(product.introductoryPricePeriodAndroid,
+            //     expectedProduct.introductoryPricePeriodAndroid);
+            // expect(product.freeTrialPeriodAndroid,
+            //     expectedProduct.freeTrialPeriodAndroid);


Is this bing deprecated?

hyochan · 2023-03-07T15:41:47Z

test/flutter_inapp_purchase_test.dart

-        http.Client mockClient = MockClient((request) async {
-          return Response(json.encode({'status': 0}), 200);
-        });


Is mocking not working or the validation functionality is gone?

hyochan · 2023-03-07T15:42:59Z

test/flutter_inapp_purchase_test.dart

-            expect(product.introductoryPriceCyclesAndroid,
-                expectedProduct.introductoryPriceCyclesAndroid);
-            expect(product.introductoryPricePeriodAndroid,
-                expectedProduct.introductoryPricePeriodAndroid);
-            expect(product.freeTrialPeriodAndroid,
-                expectedProduct.freeTrialPeriodAndroid);


Are they being deprecated 🧐?

They have been deprecated yes, these were essentially a way to make it look like an ios purchase but it's changed too much under the hood to be functional with the new Android billing

hyochan · 2023-03-07T15:53:59Z

@SamBergeron @xPutnikx @nizwar shipped as 5.4.0 🚀

deakjahn · 2023-03-19T09:40:08Z

@SamBergeron Is this still the reason why I can't see my price after upgrading to 5.4.0? I get introductoryPrice all right but nothing else, no price or localizedPrice. All Android libraries are up-to-date, price is set correctly in Google Play, it still works all right with my current release version out there, just not with the upgraded plugin here. Do I need to make changes in my code or is it just a regression of some sort?

(No subscription, just a single in-app product.)

deakjahn · 2023-03-19T09:45:51Z

By the way, small error, toString() of IAPItem has an error, it displays two items with the label introductoryPricePaymentModeIOS, the first one is superfluous, it's a repeated display of introductoryPrice.

@youssefali424

This is build off of @youssefali424 hyochan#387 PR because that one had a couple issues. It didn't pass back the prices properly for items that were created in android billing 4.0 amongst other issues. I created two new dart objects that reflect android 5.0 billing objects `SubscriptionOffer` and `PricingPhase` that pass back all the information associated with a play store item, so you can navigate those to extract introductory offers and discounted subscriptions as opposed to just having a single offer price. I've also kept the `price`, `currency` and `localizedPrice` values and made them backwards compatible with items that were updated from billing 4.0 if your app relies on those (ours did) ~~Note that the tests fail because of ios and android receipt validation only, which appears to not point to a valid URL anymore.~~

youssefali424 and others added 4 commits July 25, 2022 01:02

migrate billing to 5.0.0

fd0add4

fix kotlin error

01ba698

migrate billing to 5.0.0

8a56287

Add new dart objects to handle Android billing 5.1 subscription offer…

19a3439

…s and pricing phases Reverse compatible with billing 4.0 items that have been auto migrated to 5.0 Fixed some warnings

SamBergeron mentioned this pull request Dec 2, 2022

Any plan to support the new Google Play Billing Library 5.0? #370

Closed

SamBergeron changed the title ~~Upgrade to billing 5.1~~ Upgrade to billing 5.1 (reverse compatible) Dec 2, 2022

Re-added subscriptionPeriodAndroid and introductoryPrice for Android

62ed922

Fix issue where "default" price was a subscription offer instead of the base plan

SamBergeron added 2 commits December 5, 2022 15:25

Rename "sku" to "productId" for clarity where applicable, added the r…

5a0cea6

…equired offerToken parameter needed for billing 5.0 product purchase on Android.

Fix tests

34cbf39

nizwar mentioned this pull request Dec 6, 2022

Update offerToken and beautify modules CronometerSoftware/flutter_inapp_purchase#1

Closed

Added discount objects to tests to improve method coverage

e12fe7b

xPutnikx approved these changes Mar 1, 2023

View reviewed changes

hyochan added the feature label Mar 7, 2023

hyochan approved these changes Mar 7, 2023

View reviewed changes

hyochan merged commit 4d35e6e into hyochan:main Mar 7, 2023

hyochan mentioned this pull request Mar 20, 2023

Update to support Flutter 3 #395

Closed

deakjahn mentioned this pull request Apr 27, 2023

localizedPrice & price is null on Android #416

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to billing 5.1 (reverse compatible) #392

Upgrade to billing 5.1 (reverse compatible) #392

SamBergeron commented Dec 2, 2022 •

edited

Loading

codecov bot commented Dec 3, 2022 •

edited

Loading

nizwar commented Dec 5, 2022

SamBergeron commented Dec 5, 2022

SamBergeron commented Dec 29, 2022

SamBergeron commented Jan 17, 2023

xPutnikx left a comment

hyochan left a comment

hyochan Mar 7, 2023

hyochan Mar 7, 2023

hyochan Mar 7, 2023

SamBergeron Mar 7, 2023

hyochan commented Mar 7, 2023

deakjahn commented Mar 19, 2023 •

edited

Loading

deakjahn commented Mar 19, 2023 •

edited

Loading

Upgrade to billing 5.1 (reverse compatible) #392

Upgrade to billing 5.1 (reverse compatible) #392

Conversation

SamBergeron commented Dec 2, 2022 • edited Loading

codecov bot commented Dec 3, 2022 • edited Loading

Codecov Report

nizwar commented Dec 5, 2022

SamBergeron commented Dec 5, 2022

SamBergeron commented Dec 29, 2022

SamBergeron commented Jan 17, 2023

xPutnikx left a comment

Choose a reason for hiding this comment

hyochan left a comment

Choose a reason for hiding this comment

hyochan Mar 7, 2023

Choose a reason for hiding this comment

hyochan Mar 7, 2023

Choose a reason for hiding this comment

hyochan Mar 7, 2023

Choose a reason for hiding this comment

SamBergeron Mar 7, 2023

Choose a reason for hiding this comment

hyochan commented Mar 7, 2023

deakjahn commented Mar 19, 2023 • edited Loading

deakjahn commented Mar 19, 2023 • edited Loading

SamBergeron commented Dec 2, 2022 •

edited

Loading

codecov bot commented Dec 3, 2022 •

edited

Loading

deakjahn commented Mar 19, 2023 •

edited

Loading

deakjahn commented Mar 19, 2023 •

edited

Loading