Correctly figure out exc_info in ConsoleRenderer. #483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If the
exc_info
key was filled with a raw exception, and not a tuple,the
ConsoleRenderer
code would callsys.exc_info
and overwrite it.This is different to how the other processors handle the
exc_info
key.Additionally, if that call to
sys.exc_info
returned None, an explosionwould happen. This is the case if we placed an exception in
exc_info
,but did not actually log until outside of the
except
block.Closes #482
Pull Request Check List
typing_examples.py
.docs/api.rst
by hand.versionadded
,versionchanged
, ordeprecated
directives.Find the appropriate next version in our
__init__.py
file..rst
and.md
files is written using semantic newlines.