Prevent <<command("parameters",123)>> from crashing bondage.js

[blurymind]

Gave this another shot - this time from a different angle. Much thanks to @jhayley for the kind feedback and patience :)

There is still a quirk seen here:
https://github.com/jhayley/bondage.js/pull/40/files#diff-1f6fe15287b398db63504fd4a8ee9bbbR404
Not sure why bondage.js adds an extra space before the "("

[hylyh]

This is looking good so far! The space thing is an issue though, I think it's related to this line https://github.com/jhayley/bondage.js/blob/40748d2e50e26f40398df0a01e4d0bc070fe35e6/src/parser/parser.js#L116

[blurymind]

Ah yes, I think you're right. I had my suspicions, but now its pretty clear. I will try to tackle this tonight :)

[blurymind]

@jhayley fixed now and passing all tests :) even the new tests

[blurymind]

@jhayley After ranting with myself for a bit here, I eventually created a new 'CommandCall' token and removed the ugly hack altogether. All tests passing, simplified command parser code and anything allowed inside << >>, even spaces - without using that workaround that artificially inserts spaces

My regular expression basically takes anything that is not >> and allows it

Best part is, we no longer need this line:

      /// Extremely ugly hack because a command with spaces (e.g. <<foo bar>>)	
      /// Lexes as BeginCommand Identifier Text EndCommand	
      ['BeginCommand Identifier Text EndCommand', '$$ = new yy.CommandNode($2 + " " + $3);'],

[hylyh]

Looks good! Will push to npm when I have a chance

[blurymind]

Thank you J =)

…

On Fri, 28 Sep 2018 18:08 j hayley, ***@***.***> wrote: Merged #40 <#40> into master. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#40 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGMbVal6oKzyaGYvgMb1Jlhip79LjVmAks5uflemgaJpZM4WxEXD> .

[hylyh]

pushed! ✨