Fix sys.modules for failed imports in Python 2.7
#1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newly imported modules with compile and/or run-time errors were not being removed from `sys.modules`. This commit modifies the Python 2.7 loader so that it follows Python's failed-initial-import logic and removes the module from `sys.modules`.
brandonwillard
force-pushed
the
fix-py27-failed-import-modules
branch
from
b4af612 to
a9763b3
Compare
Kodiologist
approved these changes
Sep 30, 2018
|
Whoops, I forgot to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newly imported modules with compile and/or run-time errors were not being removed from
sys.modules. This commit modifies the Python 2.7 loader so that it follows Python's failed-initial-import logic and fixes the issue.