Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove &key #1588

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Remove &key #1588

merged 1 commit into from
Apr 27, 2018

Conversation

Kodiologist
Copy link
Member

It's redundant with &optional.

@Kodiologist
Remove &key
a605936 
It's redundant with &optional.
@gilch
Copy link
Member

gilch commented Apr 20, 2018

Related to #1411.

I have no objection to removing &key, since I never use it and it makes the let macro more complicated than necessary. If we include this functionality at all, it should be in a macro in terms of &optional, not built into the compiler.

refi64
refi64 reviewed Apr 21, 2018
View reviewed changes
Copy link
Contributor

@refi64 refi64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vodik vodik merged commit 032247e into hylang:master Apr 27, 2018
@Kodiologist Kodiologist deleted the no-amp-key branch January 20, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refi64 refi64 refi64 approved these changes

@vodik vodik vodik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kodiologist @gilch @vodik @refi64