Fix a crash in HyTypeError.__str__ #1431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refi64
requested changes
Sep 21, 2017
| # write the last line | ||
| result += ' %s\n' % colored.red("".join(source[-1])) | ||
| result += ' %s\n' % colored.green('-'*(end-1) + '^') | ||
| if all(getattr(self.expression, x, None) is not None |
There was a problem hiding this comment.
I feel like this would be a lot shorter and easier to read as just:
if hasattr(self.expression, 'start_line') and ...Or even if you decide to stick with the all route, switching to hasattr would still be best.
There was a problem hiding this comment.
The reason I used getattr(x, whatever, None) is not None instead of hasattr was that I didn't want this branch to trigger if an attribute existed but was None. We don't have anything written down saying when the attributes shouldn't exist and when they should exist but be None, so it seems safest to treat the two cases the same. That's my thinking, anyway.
|
@kirbyfan64 How do you feel about my reply? |
refi64
approved these changes
Sep 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1412.