-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more space for translated strings #431
Conversation
Thanks a lot, merged! |
My pleasure. )) |
@pvint : thanks Paul ! PS : it's here : https://github.com/hydrogen-music/hydrogen/wiki/New-features-in-Hydrogen-1.0#allow-more-space-for-translated-strings |
@trebmuh The raptor stuff was just stuff I accidentally pushed to this branch and then subsequently removed, so no worries. Good to bring it up though. :) |
@pvint: ok thanks. I was finding it strange when looking at the patch from this PR ( https://patch-diff.githubusercontent.com/raw/hydrogen-music/hydrogen/pull/431.patch ) that the line Thanks for answering that quick! |
Wow, I knew that was confusing, but the patch REALLY makes it look like other files were changed! I see what happened now though - those changes are changes that have been pulled since I last updated this branch, but I also had the changes in this branch. (speaking of confusing, I think that statement is confusing!). Summary: Those changes for raptor were added to hydrogen/master a while ago in separate pulls. I'm getting better at keeping my branches clean, but I still could improve ;) I think this will make it more clear than my explanation :) : Cheers! |
Thanks you very much for your explanation. Despite of the confusingness, I think I've got it now ! Thanks to this, I now know that I need to look at the files changed rather that the .patch for a better understanding :) You have been really great and kind here in teaching me so. Kudos to you ! |
Improvements for issue #397