Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Windows cross compile scripts for QT5 and other goodies #430

Merged
merged 5 commits into from
Nov 17, 2016

Conversation

mikotoiii
Copy link
Contributor

Added qt5 to mxe.sh
Added compilation for Windows using QT5
Added a new option (-o) called old build to compile for Windows using QT4 for backwards compatibility.
Added a new option (-r) to build releases for Windows. This will build both the 32bit and 64bit packages
Added a new option (-c) to clean the CMake files out of the windows directory, making it a fresh compile next time you run it.
Fixed up some path issues so now you can run the script from either the windows directory, or from the parent hydrogen directory. This could be used to chain load the cross compile from the main build script.

Note: I ran into some issues when making qt5 on my existing mxe installation. It hung up on the qt5system package (IIRC). I had to manually copy the new qt5system.mk file from the mxe github to the src dir in /opt/mxe and then I was able to proceed with my install (which took a little over an hour to complete). This issue should not be present on a fresh install of mxe.

@mikotoiii mikotoiii changed the title Updated Windows cross compile scripts Updated Windows cross compile scripts for QT5 and other goodies Nov 17, 2016
@mauser mauser merged commit 19fe415 into hydrogen-music:master Nov 17, 2016
@mauser
Copy link
Member

mauser commented Nov 17, 2016

Merged! Thanks for the update!

About the Qt4/Qt5 option: I suppose that we should remove Qt4 support soon, maybe after the release of a first alpha version.. So i hope that the Qt4/Qt5 duality is not present for a long time..

@mikotoiii
Copy link
Contributor Author

It will be easy enough to rip it out though like anything we'll need to spend a little time cleaning up afterwards since it checks a fair bit if it's building on qt4 or qt5.

@trebmuh
Copy link
Member

trebmuh commented Nov 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants