Velocity automation #356

elpescado · 2016-02-26T22:27:33Z

Overview

This branch allows users to adjust velocity of played notes via a timeline called "automation path":

audio

That path allows to create more complex songs using fewer patterns. It works especially nice with multi-layered drumkits.

Features

Support for built in playback (sampler)
Support for MIDI export
Saving and loading songs
Full undo&redo support
Unit tests

Prerequisites

This branch makes conserative use of C++11 features so it needs C++ support enabled (see pull request #263).

Regressions

This branch should be backwards compatible. Songs created before will get constant velocity adjustment=1.0, which means note velocities will remain unchanged.

How to test

Check whether it's possible to add points to velocity automation path, move and delete them
Check whether velocity is adjusted in playback in Song mode
Check whether notes are played with their nominal velocity in Pattern mode
Check whether note velocity is adjusted according to velocity path in exported audio file
Check whether note velocity is adjusted according to velocity path in exported MIDI file
Check whether after saving song with velocity automation path it's possible to load that song file, and velocity automation is correctly loaded

…ionPath

… XML document

… mode

trebmuh · 2016-02-28T00:09:44Z

This looks awesome ! I'll be trying to test it as soon as possible.

Does the velocity changes in the pattern part are still working ? How do you handle those ?

elpescado · 2016-02-28T10:38:18Z

Yes, it's still working. Final note velocity is computed as note own velocity * velocity adjustment from timeline * humanize factor. Range for velocity adjustment is [0, 1.5].

trebmuh · 2016-02-28T23:04:43Z

Hi @elpescado , I've been trying to build hydrogen from a fresh git clone ( 956fd11 ) with the addition of the 2 patches : https://patch-diff.githubusercontent.com/raw/hydrogen-music/hydrogen/pull/356.patch and https://patch-diff.githubusercontent.com/raw/hydrogen-music/hydrogen/pull/263.patch
but it fails building.
What would be your suggestion?

elpescado · 2016-02-29T09:41:04Z

What errors are you getting?

One thing I can think of is that this branch requires C++11 support from compiler. I created pull request which enables it, but it hasn't been merged yet: #263

elpescado · 2016-03-03T20:10:17Z

By the way, what OS/distro and which version of gcc/clang are you using? I have successfully built this branch on Debian unstable (with #263 applied before).

I18n space 397

* typos + a few fixes for the French translation * one more typo

…paths

trebmuh · 2016-12-09T10:01:40Z

@elpescado @0-wiz-0 : I'm not too sure to understand what happened here. There looks to be just a merge with current master branch, but I wonder if you reckon it would need another testing round. Please, advise.

elpescado · 2016-12-09T11:12:25Z

Hi, I merged current master to keep this branch fresh, so I don't think it needs more testing.

trebmuh · 2016-12-09T12:18:43Z

Ok, thanks.

@mauser : what do you think about merging it to master (only being curious here) ?

mauser · 2016-12-11T22:29:24Z

Hi!

Yes, i can merge this soon! (No time to test at this moment). It would be great if a label/description could be added to the left of the automation path (or a combo box later) which tells the users what this blue line is all about.

trebmuh · 2016-12-12T22:53:12Z

@elpescado : would you be able to add a "volume automation" label or something around this line?

pvint · 2016-12-13T01:11:48Z

I've been following this for a while, and I will admit that I while haven't tried it yet, this sounds really great. I will really try to test this out soon.

elpescado · 2016-12-13T08:41:30Z

Adding label is a great idea, I'll add it. I haven't really thought about it, for me it was obvious, but for first-time user, showing just blue line must indeed be confusing.

elpescado · 2017-02-06T07:31:56Z

Hi, I added label (in form of LCDCombo) to velocity path view and fixed bug that caused crash when removing points in path.

elpescado · 2017-02-17T07:01:31Z

Hi,

Is there anything that is blocking this pull request? In case anyone is interested in testing this feature, I have added "How to test" section in PR with test scenarios that came to my mind.

mauser · 2017-02-17T17:07:56Z

Hi,

tried to reach you via mail this week, but i suppose sth. went wrong if you haven't received it. I was busy for some time but will work on this one next week, maybe we can also put a first beta1-version out then...

mauser · 2017-02-17T17:11:28Z

... and of course it would be much appreciated if someone wants to test this feature :)

mauser · 2017-02-22T15:03:53Z

Thanks @elpescado , the branch is merged now! I will propably make the automation area hideable via the "View" menu or sth. similiar

trebmuh · 2017-02-27T11:50:08Z

Nice to get it in master ! Added here: https://github.com/hydrogen-music/hydrogen/wiki/New-features-in-Hydrogen-1.0

@elpescado @mauser : it looks I found a little bug, see: http://download.tuxfamily.org/librazik/volatile/bug-hydrogen-velocity-automation.mp4

elpescado · 2017-02-27T13:05:14Z

Whoops, that's embarassing:| I'll have to look into this.

trebmuh · 2017-02-27T13:15:45Z

@elpescado : no worries, let me know when/where I can help (testing mainly).

elpescado · 2017-02-27T20:21:03Z

Hi,

I have managed to find some time today. Fortunately, the "dots from outer space" bug turned out to be easy one - being able to drag points outside left margin was beacuse of comparing signed and unsigned integers. I have fixed it in my branch, elpescado:bugfix/automation (commit dbeaad7).

I'll look into "dots eating dots" bug when I find some more time. I'll create a pull request then.

trebmuh · 2017-03-01T16:17:49Z

Hi @elpescado : thanks for having tackled the "dots from outer space". That was the one I referred in my message. I'll try to find sometime soon to rebuild hydrogen with your fix and will report back to you.

About the "dots eating dots", well, ... I thought it was a feature !

Cheers.

elpescado · 2017-03-02T10:50:14Z

I am confused now;) Dots-eating-dots were by design, but after your report I thought it wasn't fortunate design. I have to think about it more... In the meantime, I have created pull request for the first bugfix.

trebmuh · 2017-03-02T11:00:04Z

I am confused now;) Dots-eating-dots were by design, but after your report I thought it wasn't fortunate design. I have to think about it more...

So it's fine. I think it is a good feature. No need to change it.

In the meantime, I have created pull request for the first bugfix.

I'll be rebuilding hydrogen with adding this patch and will report back to you after.

Thanks!

trebmuh · 2017-03-02T11:49:19Z

Rebuilt and tested. All good, thanks @elpescado !

elpescado added 24 commits June 13, 2015 22:16

Automation Paths: Create AutomationPath class

0d0d936

Automation Paths: Add velocity Automation path to Song

41faf52

Automation Paths: add iterators, operator== and operator<< to Automat…

0afff5c

…ionPath

Automation Paths: Serializer class tha loads/stores AutomationPath in…

ad86179

… XML document

Automation Paths: Use velocity automation path in hydrogen player

2f3e688

Automation Paths: Use velocity automation path in MIDI export

5a27215

Automation Paths: Load/Save automation paths in a song file

f87acf9

Automation Paths: find and move points in paths

93ede23

Automation Paths: Add AutomationPAthView widget

dc628fa

Automation Paths: Add AutomationPathView to SongEditorPanel

033aaef

Automation Paths: Display Velocity automation path in main window

b806e59

Automation Paths: Refine automation paths widget

541b5d7

Automation Path: Set 1.5 as maximum velocity adjustment

6a0c418

Automation Path: Correctly handle empty path

861f9fb

Automation Paths: Modifying AutomationPath marks song as modified

8e5758b

Automation Paths: Use velocity path only in song mode, not in pattern…

b68bd23

… mode

Merge branch 'master' into feature/automation_paths

e26cf34

Automation Paths: AutomationPath::remove_point()

aa7b795

Automation Paths: Add undo stack support for adding points

6ad11aa

AutomationPaths: Deleting points

345511b

Automation Paths: Undo removing points

1aca480

Automation Paths: Make point moves undoable

2c8444e

Automation Path: add doxygen comments

62df474

Automation Paths: Add GPL header to source files

69b2fc8

trebmuh mentioned this pull request Feb 28, 2016

Probability Engine #358

Merged

pvint and others added 6 commits December 3, 2016 21:15

Merge pull request hydrogen-music#446 from hydrogen-music/i18n_space_397

97fecf9

I18n space 397

Correct behavior when cancelling window close

0da5ee5

typos + a few fixes for the French translation (hydrogen-music#451)

ef5f80b

* typos + a few fixes for the French translation * one more typo

Added padding along left side of dialog

98f5b1f

Merge branch 'master' of https://github.com/hydrogen-music/hydrogen

cba4838

Merge remote-tracking branch 'origin/master' into feature/automation_…

39bb5e0

…paths

elpescado added 2 commits January 25, 2017 17:23

Velocity automation: add LCDCombo with description

77f1eb5

Automation Path: fix find() method not to look before first point

6e83b51

mauser merged commit b74b0de into hydrogen-music:master Feb 22, 2017

elpescado mentioned this pull request Mar 2, 2017

Automation: fix draging points outside left margin #483

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Velocity automation #356

Velocity automation #356

elpescado commented Feb 26, 2016 •

edited

Loading

trebmuh commented Feb 28, 2016

elpescado commented Feb 28, 2016

trebmuh commented Feb 28, 2016

elpescado commented Feb 29, 2016

elpescado commented Mar 3, 2016

trebmuh commented Dec 9, 2016

elpescado commented Dec 9, 2016

trebmuh commented Dec 9, 2016

mauser commented Dec 11, 2016

trebmuh commented Dec 12, 2016

pvint commented Dec 13, 2016

elpescado commented Dec 13, 2016 •

edited

Loading

elpescado commented Feb 6, 2017

elpescado commented Feb 17, 2017

mauser commented Feb 17, 2017

mauser commented Feb 17, 2017

mauser commented Feb 22, 2017

trebmuh commented Feb 27, 2017

elpescado commented Feb 27, 2017

trebmuh commented Feb 27, 2017

elpescado commented Feb 27, 2017 •

edited

Loading

trebmuh commented Mar 1, 2017 •

edited

Loading

elpescado commented Mar 2, 2017

trebmuh commented Mar 2, 2017

trebmuh commented Mar 2, 2017

Velocity automation #356

Velocity automation #356

Conversation

elpescado commented Feb 26, 2016 • edited Loading

Overview

Features

Prerequisites

Regressions

How to test

trebmuh commented Feb 28, 2016

elpescado commented Feb 28, 2016

trebmuh commented Feb 28, 2016

elpescado commented Feb 29, 2016

elpescado commented Mar 3, 2016

trebmuh commented Dec 9, 2016

elpescado commented Dec 9, 2016

trebmuh commented Dec 9, 2016

mauser commented Dec 11, 2016

trebmuh commented Dec 12, 2016

pvint commented Dec 13, 2016

elpescado commented Dec 13, 2016 • edited Loading

elpescado commented Feb 6, 2017

elpescado commented Feb 17, 2017

mauser commented Feb 17, 2017

mauser commented Feb 17, 2017

mauser commented Feb 22, 2017

trebmuh commented Feb 27, 2017

elpescado commented Feb 27, 2017

trebmuh commented Feb 27, 2017

elpescado commented Feb 27, 2017 • edited Loading

trebmuh commented Mar 1, 2017 • edited Loading

elpescado commented Mar 2, 2017

trebmuh commented Mar 2, 2017

trebmuh commented Mar 2, 2017

elpescado commented Feb 26, 2016 •

edited

Loading

elpescado commented Dec 13, 2016 •

edited

Loading

elpescado commented Feb 27, 2017 •

edited

Loading

trebmuh commented Mar 1, 2017 •

edited

Loading