-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LilyPond export #343
LilyPond export #343
Conversation
Ok, I had some time to check if this branch compiles, and it does. I've been exporting a small song made of one pattern played one time :) and I've got a .ly file which is filed with stuff. That said, I'm like a chicken in front of a fork since I never used any .ly reader/editor so I didn't get further than that yet. I'll will wait for next year I guess :) Some quick thought:
Thanks for your work and happy new year :) |
Hi, I'm starting to review this pull request.. maybe it makes sense to display a message which produces a warning which tells the user about the known limitations (btw, are tempo changes supported?). The audio export on windows was quite limited for some time, but people didn't know about this and reported this again and again to our forum and bugtracker. So clearly stating what is possible and what is not could help here. |
Hi, I did not have any time to work on Hydrogen the last few weeks, so here my response to the above comments.
|
Hi, |
Thanks, merged! |
I've been able to test it again from a today GIT fresh compile ( acb8332 ). First, I did put a note on here : https://github.com/hydrogen-music/hydrogen/wiki/New-features-in-Hydrogen-0.9.7 @Shaac : answering your points above:
Awesome work here! |
I’ll add the tempo change support when I’ll do a second run. I’ll also remove the unnecessary rests, and add support for all kits based on the new MIDI mapping. The downside is it will have the same setbacks as in issue #307 Thanks @trebmuh for your update on translatable strings. |
Sweat. The triplets functionnality would be great as well. |
Hey Shaac, I'm one of the folks who actively uses LilyPond. I also have had some experience creating songs with Hydrogen. Your work to produce LilyPond output is something I wish to praise. This comment is meant to inform you, in case you don't already know, that the LilyPond developers are actively cooperating with the "The Music Notation Project" MNMA. This indicates that there will be some sort of music "meta-language" in the future, which will be universal enough to please everybody. Instead of trying to keep up to pace with the version-to-version updates in the LilyPond community, maybe you should concentrate on the format which the MNMA is developing. If you do, then the LilyPond developers will see to it that your output can be imported into LilyPond. |
This is a first version of the LilyPond export. It should work perfectly with the following limitations:
Next step for this feature is (besides completion of these limitations) support of repeats, which will be coming soon