Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instrument volume not saved #337

Closed
thijz opened this issue Nov 26, 2015 · 4 comments
Closed

instrument volume not saved #337

thijz opened this issue Nov 26, 2015 · 4 comments

Comments

@thijz
Copy link
Member

thijz commented Nov 26, 2015

open a new song
select one of the instruments
goto instrument > layers
change the c. volume
save song

open song
c. volume is back at the default 11'

@thijz thijz added this to the 0.9.7 milestone Nov 26, 2015
@blablack
Copy link
Contributor

@thijz reproduced, but not reproduced in https://github.com/blablack/hydrogen/tree/sample_selection :)

We can wait for the pull request to be accepted or I can extract the fix.
Let me know!

@thijz
Copy link
Member Author

thijz commented Nov 29, 2015

@blablack : hi Aurelien!
good to know that there already is a fix :-)
let's just wait for the pull request to get accepted

you are refering to this request, right ? : #330

@blablack
Copy link
Contributor

@thijz sorry for the late reply!
No i meant this pull request: #291

mauser added a commit that referenced this issue Mar 28, 2016
@mauser
Copy link
Member

mauser commented Mar 28, 2016

Hi everyone!

I've split the bugfix from the pull request and put it in the master branch, the issue seems to be fixed now.

@mauser mauser closed this as completed Mar 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants