Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast pfb #206

Merged
merged 21 commits into from
Jan 8, 2025
Merged

Fast pfb #206

merged 21 commits into from
Jan 8, 2025

Conversation

wh3248
Copy link
Contributor

@wh3248 wh3248 commented Dec 20, 2024

Add a new file "fast_pfb_reader.py" that implements an performance optimized function to read pfb files.
The function is called read_files() and accepts the same arguments as parflow function read_pfb_sequence().
It is optimized to minimize the number of IO reads by computing subgrid offsets in functions rather than file lookups.
It also maximizes the number of threads used to read parallel pfb files.

The new function is integrated into hf_hydrodata.gridded.py to replace the old call to read_pfb_sequences.
There are unit tests that run only on delaware/verde with /hydrodata, but the unit tests are skipped it run on remote machines.

This also contains some changes to allow the hf_hydrodata util unit tests do not fail when run remotely.

Copy link
Collaborator

@amy-defnet amy-defnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Bill! I'm not as close to the details on the subgrid reading, but a high-level review of that looks good. The new tests are nice to ensure we're still returning the same answer as the read_pfb_sequence implementation.

@wh3248 wh3248 merged commit 97ab21d into main Jan 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants