-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast pfb #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amy-defnet
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Bill! I'm not as close to the details on the subgrid reading, but a high-level review of that looks good. The new tests are nice to ensure we're still returning the same answer as the read_pfb_sequence
implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new file "fast_pfb_reader.py" that implements an performance optimized function to read pfb files.
The function is called read_files() and accepts the same arguments as parflow function read_pfb_sequence().
It is optimized to minimize the number of IO reads by computing subgrid offsets in functions rather than file lookups.
It also maximizes the number of threads used to read parallel pfb files.
The new function is integrated into hf_hydrodata.gridded.py to replace the old call to read_pfb_sequences.
There are unit tests that run only on delaware/verde with /hydrodata, but the unit tests are skipped it run on remote machines.
This also contains some changes to allow the hf_hydrodata util unit tests do not fail when run remotely.