This repository has been archived by the owner on May 20, 2024. It is now read-only.
forked from parflow/parflow
-
Notifications
You must be signed in to change notification settings - Fork 0
Add in ApplyBCPatch macro system #16
Open
KoenigKrote
wants to merge
13
commits into
hydroframe:master
Choose a base branch
from
KoenigKrote:bc_patch_dsl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would make the most sense the finalize and merge adding boundary condition macros before continuing to review this procedure, since we want to add/merge additional OverlandFlow cases anyways |
chinwendumnjoku97
pushed a commit
that referenced
this pull request
Jun 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In progress to #9 #14 #15
Note: Primary work and changes live in
bc_faces.h
and inrichards_jacobian_eval.c
, rest of macros are setting up loop changes to work with this system.Current progress:
ForBCStructNumPatches
macroApplyBCPatch
)BCStructPatchLoopX
,GrGeomPatchLoopX
, andGrGeomOctreeFaceLoopX
macro to handleApplyBCPatch
macroNlFunctionEval
Do_
macro verbage?Do_*
macros and also use them inNlFunctionEval
)