Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow clearing game executable path and wine prefix #1254

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

JarEXE
Copy link
Contributor

@JarEXE JarEXE commented Nov 24, 2024

When submitting this pull request, I confirm the following (please check the boxes):

  • I have read and understood the Contributor Guidelines.
  • I have checked that there are no duplicate pull requests related to this request.
  • I have considered, and confirm that this submission is valuable to others.
  • I accept that this submission may not be used and the pull request may be closed at the discretion of the maintainers.

Fill in the PR content:

  • This is a quality-of-life feature for the game-options-modal that allows clearing any set executable paths as there did not seem to be any straightforward way of doing this without removing the game from your library. Linux users can also clear the wine prefix path.

@JarEXE JarEXE changed the title Allow clearing game executable path and wine prefix feat: allow clearing game executable path and wine prefix Nov 24, 2024
@thegrannychaseroperation
Copy link
Collaborator

This is brilliant. Could you attach a screenshot of how it looks?

@JarEXE
Copy link
Contributor Author

JarEXE commented Nov 29, 2024

This is brilliant. Could you attach a screenshot of how it looks?

Thanks, and sorry for the wait. Here's what it looks like.

hydrachange

hydra-2024-11-29_20.30.53trim.mp4

Copy link

sonarcloud bot commented Dec 9, 2024

@zamitto zamitto merged commit 590a15e into hydralauncher:main Dec 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants