[columnar] HYD-761 Set maximum column size #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When we are building chunk for serialization if serialzation memory is higher than 256MB, memcpy_s function (safeclib) will not copy anything (there is memory size check). Fixed by using memcpy. We have allocated already memory with required size so it should be safe to copy it.
* Metadata table is on heap. If we try to construct metadata row bigger than 1GB insert will fail at that point. Limit maximum column size to be 256MB.
JerrySievert
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
code changes a-ok, but we should wait on @wuputah's agreement before merge.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata table is on heap. If we try to construct metadata row bigger than 1GB insert will fail at that point. Limit maximum column size to be 256MB.