Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup configuration workflow #260

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

caendesilva
Copy link
Member

Fixes a path where something somehow went wrong with #257

Fixes a path where something somehow went wrong with #257
@caendesilva
Copy link
Member Author

caendesilva commented Jun 19, 2024

Okay, something is wrong here. This workflow should not have been run here.

@caendesilva caendesilva changed the title Fix wrong workflow path Fix setup configuration workflow Jun 19, 2024
@caendesilva caendesilva force-pushed the fix-wrong-workflow-path branch 2 times, most recently from 6c642ff to 20974a8 Compare June 19, 2024 16:55
@caendesilva
Copy link
Member Author

caendesilva commented Jun 19, 2024

Using run_id may be wrong: https://docs.github.com/en/actions/learn-github-actions/contexts

github.run_id string A unique number for each workflow run within a repository. This number does not change if you re-run the workflow run.

Edit: Tested and now understand this. It returns the number THIS workflow was run, not ANY workflow. I thought it was combined, but it is for this thing here:
image

@caendesilva
Copy link
Member Author

Okay, I know why the workflow was triggered, the create event runs each time a ref is created, including creating new branches. It works for the purpose as it gets triggered when the repository is created and thus the master ref is created. When cloning repositories this should not be a problem but we should add a check that it is the default branch. And I think we can hardcode it to master since that seems to be fixed by the template use action.

@caendesilva caendesilva force-pushed the fix-wrong-workflow-path branch from 56e5fb1 to 9a49558 Compare June 19, 2024 17:14
@caendesilva caendesilva merged commit bda89ba into master Jun 19, 2024
7 checks passed
@caendesilva caendesilva deleted the fix-wrong-workflow-path branch June 19, 2024 17:15
@caendesilva
Copy link
Member Author

Confirmed to be working as expected, even when cloning all branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant