Rewrite main navigation menu #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caendesilva
deleted the
59-rewrite-mobile-navigation-menus-to-prevent-duplicates
branch
caendesilva
added a commit
that referenced
this pull request
Jun 18, 2022
Clean up code and remove/replace deprecated methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the main navigation menu in accordance with #59 to keep a single source of truth for the navigation menu.
Before this PR there were two separate DOM elements for the main navigation menu. This PR merges them into one single HTML element which makes it much easier to maintain as we no longer need to keep the menus synced.
See hydephp/hyde#58 for the necessary frontend styles and script updates.