Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor author configuration system #449

Merged
merged 30 commits into from
May 23, 2022
Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented May 23, 2022

Having a whole file for defining authors and requiring having a YAML parser added more complexity than benefits, see #442.

Instead of defining author shortcuts in the authors.yml, we define them in the config/hyde.php file using the new helper:

'authors' => [
  Author::create(
    username: 'mr_hyde', // Required username
    display_name: 'Mr. Hyde', // Optional display name
    website: 'https://hydephp.com' // Optional website URL
  ),
  Author::create('john_doe', 'John Doe')
]

Fixes #446

caendesilva and others added 30 commits May 23, 2022 11:48
Breaking variable naming convention, following POLA as config keys are snake_case
@caendesilva caendesilva merged commit ce3c110 into master May 23, 2022
@caendesilva caendesilva deleted the refactor-author-system branch May 23, 2022 11:23
caendesilva pushed a commit that referenced this pull request Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Author configuration
2 participants