-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify the $page property and add a fluent metadata helper #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply fixes from StyleCI [ci skip] [skip ci]
…k into fluent-metadata-handler
Apply fixes from StyleCI [ci skip] [skip ci]
…k into fluent-metadata-handler
Apply fixes from StyleCI [ci skip] [skip ci]
…k into fluent-metadata-handler
Apply fixes from StyleCI [ci skip] [skip ci]
caendesilva
pushed a commit
that referenced
this pull request
Aug 27, 2022
…ering Add x-cloak to fix #388 documentation page flickering hydephp/develop@f468da2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking changes
The
$post
property has been renamed to$page
to unify Blade layouts. The actual contents of the property is the same, however any published views must be changed. Since themeta.blade.php
view and theconfig/hyde.php
have both been changed they too need to be republished.Metadata helper
Intended to be used in configs, the
Meta
helper gives an easy programmatic way to render HTML metadata.Plan is to merge this with blog post data. As it is now it does not take care of removing duplicates in blog posts.
Usage:
Generates:
These are then now used in the Hyde configuration.
Fixes
Fix #382
Fix #375