Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply fixes from StyleCI #277

Merged
merged 1 commit into from
May 3, 2022
Merged

Apply fixes from StyleCI #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Actions/CreatesNewPageSourceFile.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public function canSaveFile(string $path): void
/**
* Create the page.
*
* @param string $type FQDN of the page class
* @param string $type FQDN of the page class
*
* @throws Exception if the page type is not supported
*/
Expand Down Expand Up @@ -104,6 +104,7 @@ public function createMarkdownFile(): int|false

/**
* Create the Blade file.
*
* @throws Exception if the file cannot be saved.
*/
public function createBladeFile(): int|false
Expand Down Expand Up @@ -131,6 +132,7 @@ public function createBladeFile(): int|false

/**
* Create the Documentation file.
*
* @throws Exception if the file cannot be saved.
*/
public function createDocumentationFile(): int|false
Expand Down
4 changes: 1 addition & 3 deletions tests/Feature/Actions/CreatesNewPageSourceFileTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public function test_that_an_exception_is_thrown_if_file_already_exists_and_over
$this->expectExceptionMessage("File $path already exists!");
$this->expectExceptionCode(409);

new CreatesNewPageSourceFile('foo');
new CreatesNewPageSourceFile('foo');

unlink($path);
}
Expand Down Expand Up @@ -113,7 +113,6 @@ public function test_that_a_blade_file_can_be_created_and_contains_expected_cont
);
}


public function test_that_a_documentation_file_can_be_created_and_contains_expected_content()
{
(new CreatesNewPageSourceFile('682072b Test Page', DocumentationPage::class));
Expand All @@ -128,7 +127,6 @@ public function test_that_a_documentation_file_can_be_created_and_contains_expec
);
}


public function test_that_the_file_path_can_be_returned()
{
$this->assertEquals(
Expand Down