Overhaul the Markdown Converter Service to make it easier to customize and extend #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the Markdown converting process more dynamic so it can be granularly tested and utilized. The idea is to load it as a singleton in the future.
[ci skip] [skip ci]
Apply fixes from StyleCI
[ci skip] [skip ci]
Apply fixes from StyleCI
caendesilva
deleted the
allow-for-easy-additions-of-commonmark-extensions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new config that can be used to manage the default CommonMark extensions and add your own. You can also add and override the environment configuration.
Improves the main Markdown Service class by extracting parts into Service-Action Traits, and adding a more programmatic approach where settings can be changed at runtime using method chaining.