Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add further tests #156

Closed
caendesilva opened this issue Apr 21, 2022 · 4 comments
Closed

Add further tests #156

caendesilva opened this issue Apr 21, 2022 · 4 comments

Comments

@caendesilva
Copy link
Member

Currently Hyde\Framework\Models\Image has a CRAP score of 380, and has zero coverage. Needs tests, and possibly refactor.
@caendesilva
Copy link
Member Author

caendesilva commented Apr 21, 2022 •
edited
Loading

Further files with insufficient coverage

Class Coverage Fixed?
Hyde\Framework\Commands\HydeServeCommand 0% X
Hyde\Framework\Models\Image 0% X
Hyde\Framework\Actions\ServiceActions\HasMarkdownFeatures 0% X
Hyde\Framework\Models\HasFeaturedImage 11% X
Hyde\Framework\Actions\ServiceActions\HasConfigurableMarkdownFeatures 66% X

@caendesilva
Copy link
Member Author

CRAP score now at 19.

caendesilva added a commit to hydephp/hyde that referenced this issue Apr 21, 2022
@caendesilva
Fix hydephp/framework#156
70b56ff
@caendesilva
Copy link
Member Author

Reopening to track the other files needing more coverage

@caendesilva caendesilva reopened this Apr 21, 2022
@caendesilva caendesilva changed the title Fix up Hyde\Framework\Models\Image to get a lower CRAP score Add further tests Apr 21, 2022
caendesilva added a commit to hydephp/hyde that referenced this issue Apr 21, 2022
@caendesilva
Add the test tracked in hydephp/framework/issues/156
e3c9210
@caendesilva
Copy link
Member Author

All entries in the table are fixed, closing.

caendesilva added a commit to hydephp/develop that referenced this issue Jun 7, 2022
@caendesilva
Fix hydephp/framework#156
8d62a0c
caendesilva added a commit to hydephp/develop that referenced this issue Jun 7, 2022
@caendesilva
Add the test tracked in hydephp/framework/issues/156
efd1b11
caendesilva pushed a commit that referenced this issue Jul 3, 2022
Merge pull request #156 from hydephp/147-add-test-for-packagesframewo…
e1a8e6a 
…rksrccommandshydepackagediscovercommandphp

Add tests for Image::getLink() hydephp/develop@cfe254b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@caendesilva