This repository has been archived by the owner on Jun 18, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caendesilva
commented
May 10, 2022
--- | ||
title: "Page Title" | ||
label: "Sidebar Label" | ||
hidden: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L69 Not yet implemented, see hydephp/framework#310
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has been implemented.
L69 has been implemented, need to add the redirect files and prep DocsCI for merge by updating to latest Framework release and updating config to change max heading level from 4 to 3 in documentation sidebar. |
caendesilva
added a commit
to hydephp/DocsCI
that referenced
this pull request
May 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites all the documentation, with the exception of a few recently added files that were already up to date and pretty good.
Will fix the following: (unless I missed something)
Fix #17
Fix #14
Fix #12
Fix #11
Fix #10
Fix #9
For compatibility the following deleted pages should be recreated with redirects once support for hiding pages is implemented1:
Edit: Ready for merge
Footnotes
Since this behaviour has been documented it should be implemented before merging. ↩