-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking refactor to further unify sidebar and navigation API #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #498 +/- ##
=========================================
Coverage 99.95% 99.95%
- Complexity 927 929 +2
=========================================
Files 107 108 +1
Lines 2284 2300 +16
=========================================
+ Hits 2283 2299 +16
Misses 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…ydephp/develop into breaking-refactor-of-navigation-groups
…ydephp/develop into breaking-refactor-of-navigation-groups
…ydephp/develop into breaking-refactor-of-navigation-groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will breakingly remove the
DocumentationPage::$category
property and useHydePage::$navigation['group]'
instead. This will require existing documentation pages to update their front matter. However, in the end this will become more consistent and match #495.In addition and similar to the reasons in the original PR; further arguments for this change is that the naming is also inconsistent when it comes to sidebar categories and groups, for example the important DocumentationSidebar.php uses the term group exclusively, yet the front matter property is named category. Same in the NavItem class and many more places I'm sure I'll discover as I refactor this. Even the Blade views use the term groups.