fix: chart import error with virtual dataset (apache#19782)

* fix: chart import error with virtual dataset * remove unnecessary comment * resolve comment
hve-labs · May 11, 2022 · 8ecaf69 · 8ecaf69
1 parent 42a544b
commit 8ecaf69
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/superset/charts/commands/importers/v1/__init__.py b/superset/charts/commands/importers/v1/__init__.py
@@ -89,9 +89,7 @@ def _import(
                 config.update(
                     {
                         "datasource_id": dataset.id,
-                        "datasource_type": "view"
-                        if dataset.is_sqllab_view
-                        else "table",
+                        "datasource_type": "table",
                         "datasource_name": dataset.table_name,
                     }
                 )

diff --git a/superset/commands/importers/v1/examples.py b/superset/commands/importers/v1/examples.py
@@ -138,7 +138,7 @@ def _import(  # pylint: disable=arguments-differ, too-many-locals, too-many-bran
 
                 dataset_info[str(dataset.uuid)] = {
                     "datasource_id": dataset.id,
-                    "datasource_type": "view" if dataset.is_sqllab_view else "table",
+                    "datasource_type": "table",
                     "datasource_name": dataset.table_name,
                 }