migrate from external mock package to stdlib unittest.mock #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was moved to the stdlib in python 3.3, and the PyPI version is a backport for python versions less than 3.3.
briantist
added
tests
|
Hi @eli-schwartz , I apologize that I didn't get to look at this sooner. It turns out I ended up making these very changes in #1119 . It wasn't the purpose of the PR so I didn't go looking previous issues/PRs at the time. I still appreciate you putting this up and I hope you'll still open PRs for anything else you might find, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was moved to the stdlib in python 3.3, and the PyPI version is a backport for python versions less than 3.3.