[Multi DataSource] Add removedComponentIds for data source selection …

…service (opensearch-project#6920)

* add removedComponentIds for data source selection service to fallback

Signed-off-by: tygao <[email protected]>

* update comment

Signed-off-by: tygao <[email protected]>

* update component variable snapshot in navigation plugin

Signed-off-by: tygao <[email protected]>

* Changeset file for PR opensearch-project#6920 created/updated

---------

Signed-off-by: tygao <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Lu Yu <[email protected]>

changelogs/fragments/6920.yml

@@ -0,0 +1,2 @@
+feat:
+- [Multi DataSource] Add removedComponentIds for data source selection service ([#6920](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6920))

src/plugins/data_source_management/public/service/data_source_selection_service.test.ts

@@ -45,4 +45,16 @@ describe('DataSourceSelectionService service', () => {
       done();
     });
   });
+
+  it('should not store same id selection after calling remove', () => {
+    const dataSourceSelection = new DataSourceSelectionService();
+    const id = generateComponentId();
+    const dataSource = { id: 'id', label: 'label' };
+    dataSourceSelection.selectDataSource(id, [dataSource]);
+    expect(dataSourceSelection.getSelectionValue().get(id)).toStrictEqual([dataSource]);
+    dataSourceSelection.remove(id);
+    expect(dataSourceSelection.getSelectionValue().get(id)).toStrictEqual(undefined);
+    dataSourceSelection.selectDataSource(id, [dataSource]);
+    expect(dataSourceSelection.getSelectionValue().get(id)).toStrictEqual(undefined);
+  });
 });

src/plugins/data_source_management/public/service/data_source_selection_service.ts

@@ -8,14 +8,21 @@ import { DataSourceOption } from '../components/data_source_menu/types';
 
 export class DataSourceSelectionService {
   private selectedDataSource$ = new BehaviorSubject(new Map<string, DataSourceOption[]>());
+  // Some components may call onSelect function in promise.then, which could be executed later than componentWillUnmount.
+  // Use this array to record unmounted component IDs to fallback.
+  private removedComponentIds: string[] = [];
 
   public selectDataSource = (componentId: string, dataSource: DataSourceOption[]) => {
+    if (this.removedComponentIds.indexOf(componentId) > -1) {
+      return;
+    }
     const newMap = new Map(this.selectedDataSource$.value);
     newMap.set(componentId, dataSource);
     this.selectedDataSource$.next(newMap);
   };
 
   public remove = (componentId: string) => {
+    this.removedComponentIds.push(componentId);
     const newMap = new Map(this.selectedDataSource$.value);
     newMap.delete(componentId);
     this.selectedDataSource$.next(newMap);