ci: adoption of sfdx-scan-pull-request by mitch spano #6
Conversation
mmoyaferrer
commented
Feb 28, 2024
mmoyaferrer
commented
- Adoption of sfdx-scan-pull-request
- Mock metadata changes happen in the pull request in order to verify the correct behavior in the validations action, these changes will be reverted before merge.
|
Such a nice action @mitchspano, thank you for the open source and feedback to include it. |
|
What do you think about adding sfdx-scan-pull-request to the template? Also, do you prefer to configure the action to reflect the vulnerabilities as checks or comments? I personally find comments a more streamlined experience. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| System.assertEquals(Greeter.greet('John'), 'Hello John from Greeter'); | ||
| } |
There was a problem hiding this comment.
| Attribute | Value |
|---|---|
| Engine | pmd-custom |
| Category | Best Practices |
| Rule | ApexAssertionsShouldIncludeMessage |
| Severity | 3 |
| Type | Error |
| Message | 'System.assertEquals' should have 3 parameters. |
| File | force-app/main/default/classes/Test_Greeter.cls |
| update account; | ||
| } |
There was a problem hiding this comment.
| Attribute | Value |
|---|---|
| Engine | pmd-custom |
| Category | Security |
| Rule | ApexCRUDViolation |
| Severity | 1 |
| Type | Error |
| Message | Validate CRUD permission before SOQL/DML operation or enforce user mode |
| File | force-app/main/default/classes/UglyUpdateCtrl.cls |
| document.getElementById("output").innerHTML = userInput; | ||
| } |
There was a problem hiding this comment.
| Attribute | Value |
|---|---|
| Engine | eslint-custom |
| Category | undefined |
| Rule | @lwc/lwc/no-document-query |
| Severity | 2 |
| Type | Error |
| Message | Invalid usage of "getElementById". DOM query at the document level is forbidden. |
| File | force-app/main/default/lwc/helloWorld/helloWorld.js |
| document.getElementById("output").innerHTML = userInput; | ||
| } |
There was a problem hiding this comment.
| Attribute | Value |
|---|---|
| Engine | eslint-custom |
| Category | undefined |
| Rule | @lwc/lwc/no-inner-html |
| Severity | 2 |
| Type | Error |
| Message | Using 'innerHTML/outputHTML/insertAdjacentHTML' is not allowed |
| File | force-app/main/default/lwc/helloWorld/helloWorld.js |
