Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: repo template additions #1

Merged
merged 38 commits into from
Dec 6, 2023
Merged

Conversation

mmoyaferrer
Copy link
Contributor

@mmoyaferrer mmoyaferrer commented Nov 29, 2023

  • Added prettier, added its configuration
  • Prettied repository contents
  • Upgraded husky (not properly working before), and configured it to run prettier on precommit
  • Added PMD and ruleset
  • Added VSCode configuration to editor, PMD and prettier
  • Added VSCode extension recommendations
  • Added main Hutte Recipes
    • Incremental deployments recipe
    • Code Quality Scanner Recipe
    • SFDMU Recipe

Added:

  • Hutte Project Template project in Hutte QA

@mmoyaferrer
Copy link
Contributor Author

@hmayerhutte , creating this as a Draft PR for early collaboration and feedback. I'm still missing some points to do which I covered in the description of this PR.

@mmoyaferrer mmoyaferrer requested a review from amtrack November 29, 2023 18:07
@mmoyaferrer
Copy link
Contributor Author

@amtrack , happy to get suggestions from your side in this PR :)

@mmoyaferrer mmoyaferrer marked this pull request as ready for review December 3, 2023 18:48
@hmayerhutte
Copy link
Member

This looks awesome @mmoyaferrer !
Only doubt I have is about using 4 spaces as indent - this changes XML metadata from the default (and in general for my personal preference it looks too much whitespace, but that's probably just a matter of taste)

@mmoyaferrer
Copy link
Contributor Author

mmoyaferrer commented Dec 4, 2023

This looks awesome @mmoyaferrer ! Only doubt I have is about using 4 spaces as indent - this changes XML metadata from the default (and in general for my personal preference it looks too much whitespace, but that's probably just a matter of taste)

Let me change it, I feel comfortable with both, just put my default.

@mmoyaferrer
Copy link
Contributor Author

This looks awesome @mmoyaferrer ! Only doubt I have is about using 4 spaces as indent - this changes XML metadata from the default (and in general for my personal preference it looks too much whitespace, but that's probably just a matter of taste)

Let me change it, I feel comfortable with both, just put my default.

Done

@hmayerhutte
Copy link
Member

hi @mmoyaferrer thank you! could you inspect why the last build is failing with:

fatal: empty ident name (for runner@fv-az1016-860.pv3vitign2bulj5h5vrau5ekvd.cx.internal.cloudapp.net) not allowed
Error: Process completed with exit code 128.

thanks!

@mmoyaferrer
Copy link
Contributor Author

hi @mmoyaferrer thank you! could you inspect why the last build is failing with:

fatal: empty ident name (for runner@fv-az1016-860.pv3vitign2bulj5h5vrau5ekvd.cx.internal.cloudapp.net) not allowed Error: Process completed with exit code 128.

thanks!

Fixed, deltas folder was not being ignored

@amtrack
Copy link
Member

amtrack commented Dec 6, 2023

This looks awesome @mmoyaferrer ! Only doubt I have is about using 4 spaces as indent - this changes XML metadata from the default (and in general for my personal preference it looks too much whitespace, but that's probably just a matter of taste)

@hmayerhutte As far as I know, the default is 4 spaces 😄 This applies to metadata files like *-meta.xml and also Apex Classes, etc.

Examples:

Copy link
Member

@amtrack amtrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'd only like to have 4 spaces because I think this is the default.

@hmayerhutte
Copy link
Member

sorry for causing confusion with my ask for different indent .. that was motivated by seeing a metadata diff which I might have mis-interpreted... I'm of course fine with the default, so that users don't get a whitespace-diff when they update any of the metadata in salesforce and re-retrieve!
thx

@mmoyaferrer mmoyaferrer merged commit ab67c8e into main Dec 6, 2023
5 checks passed
@mmoyaferrer mmoyaferrer deleted the feature/repo-template-additions branch December 6, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants