Enable/Disable rotation flag

[maeji]

Exist app if don't went rotation enable, it should can be enable/disable rotation control.

Issue Link 🔗

A link to the issue & short explanation

Goals 🥅

What have I tried to achieve / improve + use case example

Implementation Details ✏️

• Add rotation Enable/Disable property in EKAttributes.
• Add rotation control in EKRootViewController.

Testing Details 🔍

How did I test my implementation

Screenshot Links 📷

Since this a visual project, focusing maily on UI and UX, please attach screenshots in case of UI related change

[huri000]

Thanks! Will be reviewed in the next few days.

[huri000]

@maeji - Thanks. I've reviewed your code and I have few observations:

1. Resolve the conflicts.
2. Please rename enableRotate to isRotationEnabled which is more readable and convensional.
3. Move isRatationEnabled into PositionConstraints (It is the construct that decided the constraints that applies to the position of the entry).
4. I trust you tested your implementation using the example project, yes?

Thanks!

[codecov]

Codecov Report

Merging #80 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master     #80      +/-   ##
=========================================
- Coverage    3.92%   3.91%   -0.01%     
=========================================
  Files          56      56              
  Lines        1987    1992       +5     
=========================================
  Hits           78      78              
- Misses       1909    1914       +5

Impacted Files	Coverage Δ
Source/Model/EntryAttributes/EKAttributes.swift	100% <ø> (ø)	⬆️
...yAttributes/EKAttributes+PositionConstraints.swift	27.5% <ø> (ø)	⬆️
Source/Infra/EKRootViewController.swift	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac72436...a8d69fe. Read the comment docs.

[maeji]

@huri000 I changed flag name and move to PositionConstraints. Sure I'm tested that :-) It shipped in my product. :-) Thank you!

[huri000]

Thanks! I'll review it during the weekend!

[huri000]

Great, thanks @maeji!