Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Controller Entry #44

Merged
merged 6 commits into from
Jun 8, 2018
Merged

View Controller Entry #44

merged 6 commits into from
Jun 8, 2018

Conversation

huri000
Copy link
Owner

@huri000 huri000 commented Jun 8, 2018

Issue Link 🔗

Use UIViewController as an entry #40

Goals 🥅

Display a view controller's view as an entry.

huri000 added 5 commits June 6, 2018 19:46
* master:
  Support multiple button (EKButtonBarView) as an entry.
  Bug Fix: EKAlertMessageView fail to layout all of the ButtonContents inside EKAlertMessage #41

# Conflicts:
#	README.md
#	SwiftEntryKit.podspec
Added a working sample in presets.
Documentation of SwiftEntryKit object.
@codecov
Copy link

codecov bot commented Jun 8, 2018

Codecov Report

Merging #44 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #44      +/-   ##
=========================================
- Coverage    3.88%   3.86%   -0.02%     
=========================================
  Files          55      56       +1     
  Lines        1880    1888       +8     
=========================================
  Hits           73      73              
- Misses       1807    1815       +8
Impacted Files Coverage Δ
Source/SwiftEntryKit.swift 0% <0%> (ø) ⬆️
Source/Infra/EKWindowProvider.swift 0% <0%> (ø) ⬆️
Source/Extensions/SwiftEntryKit+Execution.swift 0% <0%> (ø)
Source/Infra/EKRootViewController.swift 0% <0%> (ø) ⬆️
Source/Infra/EKContentView.swift 0% <0%> (ø) ⬆️
Source/Infra/EKEntryView.swift 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c7bbf3...f281281. Read the comment docs.

@huri000 huri000 merged commit 19dcf0d into master Jun 8, 2018
@huri000 huri000 deleted the feature/view-controller-entry branch June 8, 2018 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant