Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: EKAlertMessageView fail to layout all of the ButtonContents … #42

Merged
merged 1 commit into from
Jun 6, 2018

Conversation

huri000
Copy link
Owner

@huri000 huri000 commented Jun 6, 2018

…inside EKAlertMessage #41

Issue Link 🔗

EKAlertMessageView fail to layout all of the ButtonContents inside EKAlertMessage #41

Goals 🥅

Fixed the bug that is described in the issue above

Implementation Details ✏️

Force equal height of all the buttons in EKButtonBarView using QuickLayout.

@codecov
Copy link

codecov bot commented Jun 6, 2018

Codecov Report

Merging #42 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #42      +/-   ##
=========================================
- Coverage    3.88%   3.88%   -0.01%     
=========================================
  Files          55      55              
  Lines        1880    1881       +1     
=========================================
  Hits           73      73              
- Misses       1807    1808       +1
Impacted Files Coverage Δ
...e/MessageViews/MessagesUtils/EKButtonBarView.swift 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eb8537...b59629d. Read the comment docs.

@huri000 huri000 merged commit 757b826 into master Jun 6, 2018
@huri000 huri000 deleted the bugfix/issue-41-alert-vertical-spread branch June 6, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant