If input string is null, should return null #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunyadi
reviewed
Dec 4, 2024
| @@ -34,5 +34,5 @@ CREATE OR REPLACE FUNCTION | |||
| COMMENT = 'Parses a YAML string into a semi-structured value.' | |||
| AS | |||
| $$ | |||
| PARSE_JSON(TO_VARCHAR(YAML_TO_JSON_ARRAY(TO_BINARY(YAML_STRING, 'UTF-8')), 'UTF-8')) | |||
| CASE WHEN YAML_STRING IS NULL THEN NULL ELSE PARSE_JSON(TO_VARCHAR(YAML_TO_JSON_ARRAY(TO_BINARY(YAML_STRING, 'UTF-8')), 'UTF-8')) END | |||
There was a problem hiding this comment.
I am surprised that we need the extra CASE for NULL input; YAML_TO_JSON_ARRAY has the annotation RETURNS NULL ON NULL INPUT. Specifically, Snowflake documentation writes,
RETURNS NULL ON NULL INPUT (or its synonym STRICT) will not call the UDF if any input is null. Instead, a null value will always be returned for that row.
The same comment applies to CHECK_YAML_ARRAY and YAML_TO_JSON_STRING.
|
Sorry, you are right, ON NULL INPUT RETURNS NULL was not in the DDL definition in our current deployment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SELECT YAML_TO_JSON(null);currently fails with error: