Fix JNI AttachCurrentThread for newer jni.h versions #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently trying to use your very interesting library with the Android NDK 26, and stumbled upon an issue with a breaking API change in the
jni.hheader. Namely, the AttachCurrentThread function now acceptsJNIEnv**instead ofvoid**.I have no idea how all these JNI versions work, maybe there also needs to be an if-def as in https://github.com/leeowenowen/jni-examples/blob/070e83a5675274dc8ee86b99720723d12249cf61/invocation-interface/attach.c#L19C1-L19C1 if this is supposed to work with older versions as well.
Anyway, with the change in this PR your library now compiles again.