Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation: The 'pygments' configuration option has been renamed to 'highlighter' #26

Open
ghost opened this issue May 23, 2016 · 8 comments

Comments

@ghost
Copy link

ghost commented May 23, 2016

New version of Jekyll : Deprecation: The 'pygments' configuration option has been renamed to 'highlighter'. Please update your config file accordingly. The allowed values are 'rouge', 'pygments' or null.

Thus, _config.yml line 4, needs to be changed from :
pygments: true
to:
highlighter: pygments

paulvollmer added a commit that referenced this issue Feb 2, 2017
@makkaba
Copy link

makkaba commented May 4, 2017

especially, github page doesn't support pygments any more.
please change into highlighter: rouge
reference:
https://help.github.com/articles/page-build-failed-config-file-error/#fixing-highlighting-errors

@vivi90
Copy link

vivi90 commented May 2, 2020

Pygments is now supported by GitHub Pages.
Fixed here: https://github.com/vivi90/a-la-carte

@hunvreus
Copy link
Owner

hunvreus commented May 2, 2020

Working on a new version that has a new Jekyll configuration.

@vivi90
Copy link

vivi90 commented May 2, 2020

@hunvreus Oh nice. Why not working together on it?

@hunvreus
Copy link
Owner

hunvreus commented May 2, 2020

Sure.

I'm thinking of moving to supporting the OpenAPI standard (API spec can be stashed in _data/), updating the Jekyll set up (something closer to https://github.com/Wiredcraft/jekyll-basics) and switching to Alpine.js + Tailwind.

I'm already doing a first pass, I'll push it in another branch later on.

@vivi90
Copy link

vivi90 commented May 2, 2020

@hunvreus Interesting. I like the idea of additional support for OpenAPI :-)
Changed some structural things to eliminate annoying bugs like the post filenames for API endpoints.
Updated also the Jekyll configuration and created an release.
Libs not yet checked.

@hunvreus
Copy link
Owner

hunvreus commented Jul 5, 2020

I'm actually working on getting a lighter/simpler version of this using a single HTML file with some Tailwind and Alpine.js.

All the templating is done by Alpine.js, and I believe it will allow for a much simpler integration (can be used without installing anything, can be embedded in other documentations, etc).

If there's demand for it, I could consider porting the template over to Jekyll, but I don't see much value in doing so other than the fact that the documentation would be more easily indexed by search engines (but I believe Google is now able to process JS when indexing).

@vivi90
Copy link

vivi90 commented Jul 5, 2020

@hunvreus Sorry, not familiar with Alpine.js and Tailwind.
But every possible improvement is welcome.
What about outsourcing of "carte" and "a-la-carte" into one independent project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants