Avoid using timer.unref #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some environments where you might use stoppable don't implement timer.unref, such as the "jsdom" browser-compatibility mode of jest. This uses clearTimeout instead of unref to fix issue hunterloftis#1 in a more compatible way which still passes the test added in hunterloftis#3.
|
Note that the CI failure is unrelated to my change (it's not even the actual tests, just npm audit) |
glasser
added a commit
to apollographql/apollo-server
that referenced
this pull request
Jul 19, 2021
glasser
added a commit
to apollographql/apollo-server
that referenced
this pull request
Jul 23, 2021
glasser
added a commit
to apollographql/apollo-server
that referenced
this pull request
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some environments where you might use stoppable don't implement timer.unref,
such as the "jsdom" browser-compatibility mode of jest.
This uses clearTimeout instead of unref to fix issue #1 in a more compatible way
which still passes the test added in #3.