Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path imports to be ESM compliant #277

Closed
wants to merge 6 commits into from

Conversation

rsweeneydev
Copy link

Fixes #276

Copy link

changeset-bot bot commented Jan 13, 2024

🦋 Changeset detected

Latest commit: 699e20e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
bits-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bits-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2024 0:36am

@rsweeneydev
Copy link
Author

There are some upstream issues exposed by moving to module: NodeNext. You'll see them when you run svelte-check.

  1. melt-ui has similar issues with import specifiers missing file extensions.
  2. All the icon imports from phosphor throw the error below when running svelte-check
Error: Argument of type 'typeof LockKeyOpen' is not assignable to parameter of type 'ConstructorOfATypedSvelteComponent'.

Possible causes:
- You use the instance type of a component where you should use the constructor type
- Type definitions are missing for this Svelte Component. If you are using Svelte 3.31+, use SvelteComponentTyped to add a definition:
  import type { SvelteComponentTyped } from "svelte";
  class ComponentName extends SvelteComponentTyped<{propertyName: string;}> {} (ts)
                                                />
                                                <LockKeyOpen
                                                        class="absolute right-4 top-[14px] text-dark/30 sq-[22px]"

tsconfig.json Show resolved Hide resolved
src/content/constants.d.ts Outdated Show resolved Hide resolved
.changeset/mean-socks-wait.md Outdated Show resolved Hide resolved
src/content/api-reference/extended-types/index.d.ts Outdated Show resolved Hide resolved
@AdrianGonz97
Copy link
Collaborator

Thank you for the PR! I think we'll wait for the Melt PR to merge first (and hopefully a phosphor-svelte one soon after) before merging this one.

@saul-atomrigs
Copy link

@AdrianGonz97 Seems like the Melt-UI PR has been merged!

@AdrianGonz97
Copy link
Collaborator

Apologies for letting this sit for so long.

Due to how large of a PR this is, and how long we've let it sit for, the merge conflicts grew to so much, it was far easier to just reimplement this again rather than resolve every conflict.

Closing in favor of #352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte component libraries should use "NodeNext" for moduleResolution, not "bundler"
3 participants