Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build fail after upgrading to PrimeReact 10.3.0 (Toast component) #116

Closed
hunghvu opened this issue Jan 6, 2024 · 2 comments
Closed

Build fail after upgrading to PrimeReact 10.3.0 (Toast component) #116

hunghvu opened this issue Jan 6, 2024 · 2 comments
Labels
bug Something isn't working urgent Happen in production, need to patch ASAP web Related to the web service
Milestone

Comments

@hunghvu
Copy link
Owner

hunghvu commented Jan 6, 2024

./app/_components/richtext/button-copy.tsx:39:8
Type error: No overload matches this call.
  Overload 1 of 2, '(props: ToastProps | Readonly<ToastProps>): Toast', gave the following error.
    Property 'content' is missing in type '{ position: "bottom-center"; ref: MutableRefObject<any>; }' but required in type 'Readonly<ToastProps>'.
  Overload 2 of 2, '(props: ToastProps, context: any): Toast', gave the following error.
    Property 'content' is missing in type '{ position: "bottom-center"; ref: MutableRefObject<any>; }' but required in type 'Readonly<ToastProps>'.
@hunghvu hunghvu added bug Something isn't working web Related to the web service labels Jan 6, 2024
@hunghvu hunghvu added this to the 1.2 milestone Jan 6, 2024
@hunghvu
Copy link
Owner Author

hunghvu commented Jan 6, 2024

The content prop should be optional. Toast is working in dev, but fails in build due to TS check?

@hunghvu
Copy link
Owner Author

hunghvu commented Jan 6, 2024

This was actually a bug. The fix was introduced at primefaces/primereact#5693.

We will wait for the next release, for now, let's pin at PrimeReact to v10.2.1.

@hunghvu hunghvu changed the title Build fail since upgrading to PrimeReact 10.3.0 (Toast component) Build fail after upgrading to PrimeReact 10.3.0 (Toast component) Jan 6, 2024
hunghvu added a commit that referenced this issue Jan 6, 2024
@hunghvu hunghvu closed this as completed Jan 6, 2024
@hunghvu hunghvu added the urgent Happen in production, need to patch ASAP label Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working urgent Happen in production, need to patch ASAP web Related to the web service
Projects
None yet
Development

No branches or pull requests

1 participant