-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic support for robots.txt #82
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might be better off handling this in API Gateway?
@rmccue I had thought about that, but I assumed we'd want support for users who don't use API gateway so I included it in the function itself. What's your preferred method? |
IMO, the "function" of Tachyon is to serve images, not to be a full server. The robots.txt stuff I think makes more sense in API Gateway, since that's the routing layer; we were just lazy and said "route everything to Tachyon". We provide the API Gateway configuration, so we can PR it into there. Maybe @joehoyle has other thoughts on this though? |
I think it's fine being here for convenience, there's a fair bit more work when trying to use APIGateway, especially as that also will need to go through cloudformation. As Japh mentioned, the |
Looks wrong, but it's not 😄
(% in my terminal signifies end of the response) |
@Japh pingy ping |
ᕕ( ᐛ )ᕗ Ping! @Japh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naise!
This is to prevent issues where services, such as Twitter, aren't able to generate a card because
/robots.txt
is missing from Tachyon's domain.