Return 404 for non-existent file #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catches exception when fetching a file from S3. If it's `AccessDenied`, response code from the lambda invokation will be 404.
jerico
requested review from
joehoyle,
rmccue,
kovshenin,
wisyhambolu and
ferschubert-hm
kovshenin
suggested changes
Mar 13, 2024
kovshenin
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tachyon currently returns an empty body with
200response code when an exception is raised when fetching a file from S3.This PR adds error handling specifically for
AccessDeniedexceptions. When this exception occurs, the Lambda invocation’s response code will be set to 404, aligning with how Tachyon v2 handles similar exceptions.Fixes #176