Support alternative method of passing Presigned params #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is a presign param, we need to decode it and add it to the args. This is to provide a secondary way to pass pre-sign params, as using them in a Lambda function URL invocation will trigger a Lambda error.
kovshenin
approved these changes
Feb 28, 2024
rmccue
requested changes
Feb 28, 2024
tests/test-private-upload.ts
Outdated
| { | ||
| region: process.env.S3_REGION, | ||
| bucket: process.env.S3_BUCKET, | ||
| } as S3ClientConfig |
There was a problem hiding this comment.
Why is this required? Is there a type error here?
There was a problem hiding this comment.
Yeah this was copied from the lib.ts. It seems the ts types don't account for this style of passing these times for some reason. Mostly just copied it though
| /** | ||
| * Middleware to remove the x-id query string param form the GetObject call. | ||
| */ | ||
| const middleware: MiddlewareType<any, any> = ( next: any, context: any ) => async ( args: any ) => { |
There was a problem hiding this comment.
Can these be more specifically typed?
There was a problem hiding this comment.
They could but it's a test so I'm not that worried
tests/test-private-upload.ts
Outdated
Comment on lines
46
to
51
| let queryStringParameters: Args = {}; | ||
| presignedUrl.searchParams.forEach( ( value, key ) => { | ||
| queryStringParameters[ key as keyof Args ] = value; | ||
| } ); | ||
|
|
||
| return queryStringParameters; |
There was a problem hiding this comment.
Maybe: Object.fromEntries( presignedUrl.searchParams ) ?
There was a problem hiding this comment.
Ah that's the function I was looking for I think!
rmccue
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow passing
?presign={signature params}to work around lambda not allowing the pre-soign params directly.