Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Jekyll 4, add docs for Front Matter layout defaults #11

Merged
merged 8 commits into from
Feb 10, 2023

Conversation

joeleenk
Copy link
Contributor

@joeleenk joeleenk commented Feb 9, 2023

We want all of our open source projects to be able to use this theme with as minimal setup and repetition as possible. But it appears we need Jekyll 4 to inherit site variables from the theme config. Inheriting the variables also seems to only work from GitHub hosted Gems, and not from RubyGems, so we'll switch to using the Gem from this repo. (If someone knows why or some other way to solve this, please let me know.)

This PR also:

  • Adds docs for adding Front Matter layout defaults to the config file so that all markdown files don't need to specify a layout. This fixes a problem we found with Webpack Helpers not loading the theme properly if we removed the github-pages gem. Note: this does not appear to inherit and will need to be set in the site's config file.
  • Removes the HM homepage link from the header, so that it's not forced to inherit to all of the other sites. (If those sites also want links in the header, it gets a bit crowded.)

@joeleenk joeleenk self-assigned this Feb 10, 2023
@joeleenk joeleenk changed the title Update to Jekyll 4, add layout default to config Update to Jekyll 4, add docs for Front Matter layout defaults Feb 10, 2023
Copy link

@kadamwhite kadamwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great solution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants