Handle missing x-amz-target header #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases - particularly on local environments `$request_id` can be truthy but empty, or without offset 0 being set, additionally the `x-amz-target` header isn't always set in requests to S3. This update ensures both cases don't cause warnings to be output but rather falls back to reasonable defaults. A missing `x-amz-target` header will give `amz-unknown-target` as the value if it's not set.
![hm-linter[bot]](https://avatars.githubusercontent.com/in/5455?s=60&v=4){kind=small}
joehoyle
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases - particularly on local environments
$request_idcan be truthy but empty, or without offset 0 being set, additionally thex-amz-targetheader isn't always set in requests to S3. This update ensures both cases don't cause warnings to be output but rather falls back to reasonable defaults.A missing
x-amz-targetheader will giveamz-unknown-targetas the value if it's not set.