Improve endpoint updates #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to just use the put events command to update endpoints so we can remove the update endpoint command requirement. This also has the effect of ensuring the endpoint is always in sync with the event records as there is no race condition between the initial update endpoint call and the first event being recorded. Lastly it also removes an unnecessary HTTP request to update endpoint separately.
![hm-linter[bot]](https://avatars.githubusercontent.com/in/5455?s=60&v=4){kind=small}
rmccue
approved these changes
Mar 12, 2020
|
I'll do a full code-style sweep in a separate PR 👍 |
this prevents stale data being supplied for endpoint attributes
roborourke
added a commit
to humanmade/altis-local-server
that referenced
this pull request
Mar 14, 2020
This brings in support for creating and updating endpoints via the putEvents method as per production. This is needed to support the new method for updating endpoints brought in with the changes in humanmade/aws-analytics#38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to just use the put events command to update endpoints so we can remove the update endpoint command requirement. This also has the effect of ensuring the endpoint is always in sync with the event records as there is no race condition between the initial update endpoint call and the first event being recorded.
Lastly it also removes an unnecessary HTTP request to update endpoint separately.