Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct css enqueuing logic #26

Merged
merged 3 commits into from
Jul 21, 2020
Merged

Correct css enqueuing logic #26

merged 3 commits into from
Jul 21, 2020

Conversation

kadamwhite
Copy link
Collaborator

This addresses the one key remaining issue from #22, which was that it was not possible to enqueue_asset( 'style.css' ) in a dev server environment because the enqueuing logic would not be aware that style.css had been coerced to style.js because that was all that was available in the dev manifest (which does not include extracted CSS).

@kadamwhite kadamwhite requested a review from mikeselander July 21, 2020 22:53
Copy link
Collaborator Author

@kadamwhite kadamwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

輝きながら
君が教えてくれた

Ah…
You Only Live Once

Mergin'

@kadamwhite kadamwhite merged commit 9e14f74 into main Jul 21, 2020
@kadamwhite kadamwhite deleted the correct-css-enqueuing-logic branch July 21, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant