Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce register_asset() and enqueue_asset() functions; refactor & test plugin #22
Introduce register_asset() and enqueue_asset() functions; refactor & test plugin #22
Changes from 26 commits
152349f
2cc9705
9d3ba7b
5d4d240
314c05f
b57c4b4
d77b114
fa62dc4
fe13729
5e766a6
32324f4
3e6a7a9
b66dfa1
2220e57
51715ce
f45f962
5c0dcbb
3b5c0c6
213b4dd
2c2fab8
1cf2d0b
e2327a4
ebf9d1f
729305c
e5716bf
8b9e72c
28ace0a
d881e63
cd9611c
6f545d6
de59196
93e3782
6d070f5
01936ab
e9f6453
faf56db
31fa16b
6cf6f1b
0609d7e
fd70cf2
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is
PHP_CodeSniffer
expected as global dependency? Why is PHPUnit a local one (which I absolutely prefer)?Since the config file has a default name, it will automagically get picked up. No need to specify:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the same for me. If I do not manually specify the ruleset, it uses a completely different set of standards. Am I possibly using an invalid ruleset name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right. Sorry, my bad. The supported name would be
phpcs.xml(.dist)
. (Or others.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahah! Thanks!