Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 692 to v21 branch #770

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Backport 692 to v21 branch #770

merged 2 commits into from
Dec 18, 2024

Conversation

mikelittle
Copy link
Contributor

Backport PR #692 to v21

filter182 and others added 2 commits December 17, 2024 16:40
@filter182 @mikelittle
Fixing 404s on subdomains with dashs on it
3f086f9
@mikelittle
Adjust the Regex
30fb736 
If the hyphen is the last in the character class it does not need to be escaped.
filter182
filter182 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@filter182 filter182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikelittle mikelittle merged commit f91fc12 into v21-branch Dec 18, 2024
1 check passed
@mikelittle mikelittle deleted the backport-692-to-v21-branch branch December 18, 2024 10:20
@mikelittle mikelittle removed the request for review from abhishek-kaushik December 18, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filter182 filter182 filter182 approved these changes

@jerico jerico Awaiting requested review from jerico

@ferschubert-hm ferschubert-hm Awaiting requested review from ferschubert-hm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikelittle @filter182