-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Afterburner support to Local Server #634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a typo in the docs. And a lint issue about quotes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still a linter issue about double quotes vs single quotes, but otherwise, looks good to me
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport v16-branch
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick 793982e5c0bc8e57e5c2e3c1ad6fb76c06292d23 4fd7933dfa3b50c37b2999fbec44ece99e1a8627 9c11880e396e3f51c00e9572b0b38d2f9202cd99
# Create a new branch with these backported commits.
git checkout -b backport-634-to-v16-branch
# Push it to GitHub.
git push --set-upstream origin backport-634-to-v16-branch
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport Then, create a pull request where the |
No description provided.